update shadow values. now with ∞ more umbra #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| --shadow-elevation-1: { | ||
| box-shadow: 0 1px 4px 0 rgba(0, 0, 0, 0.37); | ||
| box-shadow: 0 2px 2px 0 rgba(0, 0, 0, 0.14), |
There was a problem hiding this comment.
Can you do this?
mixin(--shadow-elevation-2dp);
There was a problem hiding this comment.
Cannot right now due to Polymer/polymer#1399 :(
|
Needs more umbra. lgtm |
|
FYI, I will also open PR's to elements using shadows to switch to the |
| --shadow-elevation-2dp: { | ||
| box-shadow: 0 2px 2px 0 rgba(0, 0, 0, 0.14), | ||
| 0 1px 5px 0 rgba(0, 0, 0, 0.12), | ||
| 0 3px 1px -2px rgba(0, 0, 0, 0.2); |
|
LGTM |
morethanreal
pushed a commit
that referenced
this pull request
Apr 29, 2015
update shadow values. now with ∞ more umbra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shyndman @cdata @notwaldorf @nevir PTAL