-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importing typography.html causes ie & edge to lose shadows and elevation #144
Comments
I did some more digging and it appears that it's the Roboto font from Google Fonts that's causing the issue. If I comment out the following import link: everything works. This link is in the roboto.html file which is imported in the typography.html file. Edge appears to have a problem with the Google Font Roboto. |
I tested a second site. It's not just the Robot font, it appears to be any Google font loaded with a link. I tested further and it appears to be a timing/caching issue. If I comment out the Roboto font link in the roboto.html file and place it in the index.html file, everything works in Edge. |
This issue happens to me too. However it's a lot of different styles breaking, possibly related to CSS variables. It also happens with all Google Fonts. It works when putting the link-tag in the index.html. Could this have something to do with polyfilled HTML imports having link-tags with rel="stylesheet" inside them? |
/cc @valdrinkoshi |
Can you share the list of the installed bower dependencies? I noticed that polymer starter kit is still pointing to
Here's my updated {
"name": "polymer-starter-kit",
"authors": [
"The Polymer Authors"
],
"license": "https://polymer.github.io/LICENSE.txt",
"dependencies": {
"app-layout": "PolymerElements/app-layout#^2",
"app-route": "PolymerElements/app-route#^2",
"iron-flex-layout": "PolymerElements/iron-flex-layout#^2",
"iron-iconset-svg": "PolymerElements/iron-iconset-svg#^2",
"iron-media-query": "PolymerElements/iron-media-query#^2",
"iron-pages": "PolymerElements/iron-pages#^2",
"iron-selector": "PolymerElements/iron-selector#^2",
"paper-icon-button": "PolymerElements/paper-icon-button#^2",
"polymer": "Polymer/polymer#^2",
"webcomponentsjs": "webcomponents/webcomponentsjs#^1",
"paper-button": "PolymerElements/paper-button#^2"
},
"devDependencies": {
"web-component-tester": "Polymer/web-component-tester#^6"
},
"private": true
} |
Here's my bower.json: { The paper-input or paper-dialog elements cause the problem. You didn't bring in paper-input or paper-dialog. You will see the shadows from paper-button or paper-card disappear. My project worked at the stage yours is as well. It wasn't until paper-input or paper-dialog was added that things started to go haywire. |
I didn't include In this repository you can find my setup - https://github.com/valdrinkoshi/paper-styles-144 bower.json{
"name": "polymer-starter-kit",
"authors": [
"The Polymer Authors"
],
"license": "https://polymer.github.io/LICENSE.txt",
"dependencies": {
"app-layout": "PolymerElements/app-layout#^2",
"app-route": "PolymerElements/app-route#^2",
"iron-flex-layout": "PolymerElements/iron-flex-layout#^2",
"iron-iconset-svg": "PolymerElements/iron-iconset-svg#^2",
"iron-media-query": "PolymerElements/iron-media-query#^2",
"iron-pages": "PolymerElements/iron-pages#^2",
"iron-selector": "PolymerElements/iron-selector#^2",
"paper-icon-button": "PolymerElements/paper-icon-button#^2",
"polymer": "Polymer/polymer#^2",
"webcomponentsjs": "webcomponents/webcomponentsjs#^1",
"paper-button": "PolymerElements/paper-button#^2",
"paper-dialog": "PolymerElements/paper-dialog#^2",
"paper-card": "PolymerElements/paper-card#^2",
"paper-input": "PolymerElements/paper-input#^2.0.0"
},
"devDependencies": {
"web-component-tester": "Polymer/web-component-tester#^6"
},
"private": true
} installed dependencies (
|
I deleted the bower_components folder and reinstalled. |
Description
I've upgraded to Polymer 2.0, not hybrid. When using any element that imports typography.html from paper-styles, IE & Edge lose the shadows and elevations. Chrome and Firefox show not issues. I'm unable to test on Safari.
I started a project from scratch using polymer-cli and added a paper-card, paper-button, iron-icon and paper-input one at a time trying to find the problem. Paper-input caused the failure. I traced it to typography.
If I simply import typography.html in my shared-styles it causes the problem as well, so it isn't the paper-input element.
Expected outcome
Shadows and elevations should be unaffected.
Actual outcome
Shadows dissapear and all buttons and cards show only the text.
Live Demo
Steps to reproduce
Browsers Affected
No bower_components/paper-styles/typography.html imported
With typography.html imported
The text was updated successfully, but these errors were encountered: