2.0 preview #91
2.0 preview #91
Conversation
|
Hmm, have we decided we're doing this |
|
ugh, my bad, |
valdrinkoshi
force-pushed
the
2.0-preview
branch
2 times, most recently
from
4e064c7
to
9188025
Compare
valdrinkoshi
force-pushed
the
2.0-preview
branch
from
9188025
to
4786f2a
Compare
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
2.0-preview updates to travis.yaml, bower.json, and more
valdrinkoshi
force-pushed
the
2.0-preview
branch
from
55d4fbe
to
7e9bf4d
Compare
Change Travis to Chrome beta
| @@ -111,16 +105,16 @@ | |||
| color: #646464; | |||
| } | |||
|
|
|||
| .icon-button.red > iron-icon::shadow path { | |||
bower.json
Outdated
| "iron-icons": "polymerelements/iron-icons#2.0-preview", | ||
| "iron-test-helpers": "PolymerElements/iron-test-helpers#2.0-preview", | ||
| "iron-demo-helpers": "PolymerElements/iron-demo-helpers#2.0-preview", | ||
| "test-fixture": "PolymerElements/test-fixture#^3.0.0-rc.1", |
There was a problem hiding this comment.
WCT 4 & 6 have the right versions of test-fixture now.
test/paper-ripple.html
Outdated
| @@ -208,20 +208,22 @@ | |||
| done(); | |||
| }); | |||
| Polymer.dom(rippleContainer).appendChild(ripple); | |||
| window.ShadyDOM && window.ShadyDOM.flush(); | |||
There was a problem hiding this comment.
Maybe this should be moved into ElementMetrics's boundingRect getter? (another couple below on L226, L246) This seems like the same problem as this iron-fit-behavior thread. I hope your ShadyDOM issue gets a reasonable fix; it would be really nice if ShadyDOM wrapped stuff like this so it could flush automatically.
There was a problem hiding this comment.
I think it's reasonable to flush in the tests. I could also wait for afterNextRender, but I didn't want to bring too many changes :)
There was a problem hiding this comment.
(from offline) A note here would be good.
| @@ -150,6 +150,8 @@ | |||
| </dom-module> | |||
| <script> | |||
| (function() { | |||
| 'use strict'; | |||
test/paper-ripple.html
Outdated
| @@ -208,20 +208,28 @@ | |||
| done(); | |||
| }); | |||
| Polymer.dom(rippleContainer).appendChild(ripple); | |||
| // NOTE: shadydom will apply upgrades async for | |||
There was a problem hiding this comment.
shadydom will apply upgrades async
Isn't this because distribution is async?
There was a problem hiding this comment.
right, "will apply distribution" is much more correct than a generic "will apply upgrades"..Updating it
demo-snippetin demo page::shadowin demo page