Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paper-ripple fails to fill paper-toolbar with "tall" class #80

Open
tilden opened this issue May 31, 2016 · 0 comments
Open

paper-ripple fails to fill paper-toolbar with "tall" class #80

tilden opened this issue May 31, 2016 · 0 comments

Comments

@tilden
Copy link

tilden commented May 31, 2016

Description

When a paper-ripple element is used inside a paper-toolbar element with the tall class, the paper-ripple effect only fills the toolbar's top area.

Expected outcome

The ripple effect should encompass the entire area of the toolbar

Actual outcome

The ripple effect only fills the toolbar's top area, and not the rest of it

Live Demo

Note that only the top third of the toolbar shows the ripple effect:
https://jsbin.com/gukolecipi/edit?html,output

Steps to reproduce

  1. Put a paper-toolbar element in the page.
  2. Put a paper-ripple element inside said paper-toolbar

Browsers Affected

Verified in

  • Chrome
  • Firefox
  • Safari 9.1

Workarounds

A similar issue was noted on StackOverflow here:
http://stackoverflow.com/questions/33182299/paper-ripple-fill-sibling-element-in-paper-toolbar
The suggested workaround, however, breaks scrolling for waterfall-style headers.

@tilden tilden changed the title Paper ripple fails to fill paper-toolbar with "tall" class paper-ripple fails to fill paper-toolbar with "tall" class May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant