-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style mixin for input-wrapper #607
base: master
Are you sure you want to change the base?
Conversation
I have a requirement to display paper-dropdown-menu as a standard dropdown and not in material design. I need to do it through stylesheet as few of our customer still want to have old look/feel and we do not want to have custom coding instead trying to change the look/feel using styles. I am able to display paper-input like legacy elements easily by using paper-input-container styles but no luck with dropdown.
Change for adding a mixing to style input wrapper
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it.
…On Tue, Jan 16, 2018 at 9:13 PM, googlebot ***@***.***> wrote:
Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 *Please visit https://cla.developers.google.com/
<https://cla.developers.google.com/> to sign.*
Once you've signed, please reply here (e.g. I signed it!) and we'll
verify. Thanks.
------------------------------
- If you've already signed a CLA, it's possible we don't have your
GitHub username or you're using a different email address on your commit.
Check your existing CLA data <https://cla.developers.google.com/clas>
and verify that your email is set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
- If your company signed a CLA, they designated a Point of Contact who
decides which employees are authorized to participate. You may need to
contact the Point of Contact for your company and ask to be added to the
group of authorized contributors. If you don't know who your Point of
Contact is, direct the project maintainer to go/cla#troubleshoot. The email
used to register you as an authorized contributor must be the email used
for the Git commit.
- In order to pass this check, please resolve this problem and have
the pull request author add another comment and the bot will run again. If
the bot doesn't comment, it means it doesn't think anything has changed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#607 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AhDsgziPWCdYF63YIvpOTp-4jfWfkBpGks5tLVcugaJpZM4RgtOx>
.
|
CLAs look good, thanks! |
First, I can't tell anything from the diff since it looks like you've replaced the whole file? Secondly, do you have an example of exactly what you want to achieve, and why you can't use the existing mixins? |
I have a requirement to display paper-dropdown-menu as a standard dropdown and not in material design. I need to do it through stylesheet as few of our customer still want to have old look/feel and we do not want to have custom coding instead trying to change the look/feel using styles. I am able to display paper-input like legacy elements easily by using paper-input-container styles but no luck with dropdown.
Styling input wrapper will provide enterprise application to serve the customer needs without changing the underline code.