[Fixes #274] Add the new required text fields (December 2015 release of the materi… #371
Conversation
| @@ -83,6 +83,7 @@ | |||
| `--paper-input-container-color` | Label and underline color when the input is not focused | `--secondary-text-color` | |||
| `--paper-input-container-focus-color` | Label and underline color when the input is focused | `--primary-color` | |||
| `--paper-input-container-invalid-color` | Label and underline color when the input is is invalid | `--error-color` | |||
| `--paper-input-container-required-color` | Color used for the asterix displayed for required input | `--error-color` | |||
There was a problem hiding this comment.
I am not sure there's a need for this. From the mocks, the * is the same color as the error color, and I don't think there's a need for that to be different.
…al design spec) taken into account feedback
|
@notwaldorf I took into account your remark and squashed the commit! |
|
@notwaldorf friendly ping! :) |
|
I love this PR. Good job @MeTaNoV 👍 |
|
Thx @florent1933 , somehow get lost... @notwaldorf is |
|
Maybe not... |
|
paper-input is still under focus, but this PR can't be merged because it needs a rebase. Secondly, in its current form, I am not super convinced it's not a breaking change to the 1.0 version, so I'm not sure it can even be merged in 1.0 |
|
@notwaldorf this means I have to work a bit for Polymer Team? I have busy with Machine Learning @ Google right now.... Next week, maybe... Thanks for the follow-up BTW!! |
|
@notwaldorf shall I rebase for 2.0? |
Fixes #274 :
Add the new required text fields (December 2015 release of the material design spec)