Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why the transition on the paper-drawer-panel is on ease-in-out? #99

Closed
ddadon10 opened this issue Sep 30, 2015 · 3 comments
Closed

Why the transition on the paper-drawer-panel is on ease-in-out? #99

ddadon10 opened this issue Sep 30, 2015 · 3 comments

Comments

@ddadon10
Copy link

Hi,

Just a question about the transition on the paper-drawer-panel :

When the drawer is hide (e.g : on mobile) you can swipe on the edge for display the panel : OK

But the CSS transition has a little "glitch" i think, because you can see a little "lag" when you slide from the edge (specifically when you detach your finger from the screen before the panel is fully extended)

I've seen that the transition is on "ease-in-out". And it's more fluid if i set the transition on "ease-out" or "out-quadratic"

So : Why the polymer dev team put the transition on "ease-in-out" ?

Thanks ! :)

Don't hesitate to contact me if you want more explanation about my issue !

Oh, and sorry for my english !

@blasten
Copy link
Contributor

blasten commented Oct 26, 2015

Feel free to send a PR and make this a custom property. e.g. --paper-drawer-panel-timing-function. The default could be ease-out

@WoodyWoodsta
Copy link

Would the user not want to specify the transition duration as well (as I would like to 😄 ). I would submit a PR but there is one already. But here is a suggestion with a --paper-drawer-panel-transition-duration custom property included (related to #110 (comment)):

.transition > #drawer {
  transition-property: transform, width, visibility;
  -webkit-transition-property: -webkit-transform, width, visibility;

  transition-timing-function: var(--paper-drawer-panel-timing-function, ease-out);
  -webkit-transition-timing-function: var(--paper-drawer-panel-timing-function, ease-out);

  transition-duration: var(--paper-drawer-panel-transition-duration, 0.3s);
  -webkit-transition-duration: var(--paper-drawer-panel-transition-duration, 0.3s);
}

@blasten
Copy link
Contributor

blasten commented Jan 28, 2016

Feel free to send a PR for this issue. This one was closed: #110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants