Follow Material Design spec better #142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Padding, font, border radius, disabled state and icon
|
This would make it in-keeping with other implementations of material design (Angular Material, Material Design Lite, Materialize, Vue Material, etc.), but do you think that a margin should be added between the icon and text? |
|
@matthewpull Sorry for late answer, but I personally think margin should be responsibility of the developer itself. But it's my opinion only. Someone may think otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
My suggestion
(Disabled button wraps to new line in the demo because of its width. This need to be fixed.)
Changes
Related: #129