Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus behavior: Change background-color instead of font-weight #95

Closed
jhrdina opened this issue Jan 25, 2016 · 3 comments
Closed

Focus behavior: Change background-color instead of font-weight #95

jhrdina opened this issue Jan 25, 2016 · 3 comments
Assignees

Comments

@jhrdina
Copy link

jhrdina commented Jan 25, 2016

Buttons should use background-color change for focus instead of font-weight change.

Expected outcome

Button's background becomes darker on focus as mentioned in Google Design Spec and implemented in material-design-lite (their css). The font-weight is not changed (default font-weight should be 500 as mentioned in #94).

after
Image: material-design-lite demo, their CSS implementation here

Actual outcome

Button's font-weight changes on focus, background stays the same.

before
Image: paper-card demo

@abdonrd
Copy link
Member

abdonrd commented Jan 25, 2016

👍

@keanulee
Copy link
Contributor

We decided to use font-weight to show focus state instead of background color because we have received feedback that background-color may not provide enough contrast for a11y. For this reason, we cannot change the font-weight in #94 because that would be too close to the focus state.

@abdonrd
Copy link
Member

abdonrd commented Jan 28, 2016

@keanulee oh! :(

Then you should change the spec of MD?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants