Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[disabled] state should respect [raised] #127

Open
icmdaf opened this issue Jul 12, 2016 · 4 comments
Open

[disabled] state should respect [raised] #127

icmdaf opened this issue Jul 12, 2016 · 4 comments

Comments

@icmdaf
Copy link

icmdaf commented Jul 12, 2016

The current default style applies a background color to all disabled buttons.
But according to the material spec, flat disabled buttons don't have a background, just gray text.

Can we split the style and align it closer with the spec (also using the theme colors for disabled text instead of the hardcoded grey value etc)

:host([disabled]:not([raised])) {
  ...
  @apply(--paper-button-disabled);
  @apply(--paper-button-flat-disabled);
}
:host([disabled][raised]) {
  ...
  @apply(--paper-button-disabled);
  @apply(--paper-button-raised-disabled);
}
@keanulee
Copy link
Contributor

@notwaldorf Would this be considered a breaking change? (If so, something to add to the backlog when we do bump versions.)

@notwaldorf
Copy link
Contributor

notwaldorf commented Jul 12, 2016

Ugh, I'm confused about the spec. The image shows the flat disabled buttons not having a background, but the video below it shows them as having one.

Someone should double check this with @zgibson :)

@notwaldorf
Copy link
Contributor

notwaldorf commented Jul 12, 2016

@keanulee: to answer your question: Depending on what we decide is correct, I would maybe consider this a breaking change, yes.

@anentropic
Copy link

I find it bizarre that the raised button 'raises' further when you press on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants