Update to new observers API. Remove redundant configure call. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
sorvell
pushed a commit
that referenced
this pull request
Apr 18, 2015
Update to new observers API. Remove redundant configure call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is dependent on Polymer/polymer#1422 being merged, and updates to match the new
observersAPI, which now takes an array of string-based method signatures.The
configurecall was also unnecessary afaict, since all properties correctly have default values specified inproperties. Theconfigurefunction will likely be deprecated at some point now that we have the per-propertyvaluefield.