Skip to content
This repository has been archived by the owner on Dec 28, 2024. It is now read-only.

Handle src url errors #36

Closed
opus1269 opened this issue Nov 5, 2015 · 5 comments
Closed

Handle src url errors #36

opus1269 opened this issue Nov 5, 2015 · 5 comments
Assignees

Comments

@opus1269
Copy link
Contributor

opus1269 commented Nov 5, 2015

The element doesn't let you know when a url is bad. It also does not handle re-setting the src after it was set to a bad url correctly. I have submitting a pull request to address this.
#35

@Negashev
Copy link

+1

@kevin-wise
Copy link

Seems like this is a duplicate of #33

@opus1269
Copy link
Contributor Author

Yes. I'm not concerned about the implementation details, as long as there is a property indicating the load failed and you can set the src after querying that.

@jonnenauha
Copy link

#33 was closed due to the fallback src. I kind of agree it gets a bit too complicated with it. This #35 looks simple and fixes real issues. The error bool will allow people to implement their own fallback mechanism (also, as setting src again is now supported without hacks ;)

@bicknellr
Copy link
Contributor

Release 1.1.0 now includes error property support.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants