Merge pull request #64 from PolymerElements/unpressed-when-unfocused

Button should not stay pressed when it becomes unfocused
PolymerElements · Apr 18, 2017 · 4d79ebb · 4d79ebb
2 parents 4c85dc5 + 46cc9bd
commit 4d79ebb
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/iron-button-state.html b/iron-button-state.html
@@ -91,7 +91,7 @@
     },
 
     observers: [
-      '_detectKeyboardFocus(focused)',
+      '_focusChanged(focused)',
       '_activeChanged(active, ariaActiveAttribute)'
     ],
 
@@ -112,6 +112,14 @@
       }
     },
 
+    _focusChanged: function(focused) {
+      this._detectKeyboardFocus(focused);
+
+      if (!focused) {
+        this._setPressed(false);
+      }
+    },
+
     _detectKeyboardFocus: function(focused) {
       this._setReceivedFocusFromKeyboard(!this.pointerDown && focused);
     },

diff --git a/test/active-state.html b/test/active-state.html
@@ -125,6 +125,16 @@
             });
           });
         });
+
+        suite('on blur', function() {
+          test('the pressed property becomes false', function() {
+            MockInteractions.focus(activeTarget);
+            MockInteractions.down(activeTarget);
+            expect(activeTarget.hasAttribute('pressed')).to.be.eql(true);
+            MockInteractions.blur(activeTarget);
+            expect(activeTarget.hasAttribute('pressed')).to.be.eql(false);
+          });
+        });
       });
 
       suite('without toggles attribute', function() {