-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer leads to an error in combination with disable-upgrade
.
#71
Conversation
Fixes an issue where an element with this behavior and `disable-upgrade` throws an error when the element gets `detached`.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
This is no longer the case with Polymer 2.x or 1.x |
Oh wow, that looks more a Polymer bug rather than of this behavior... Updated the jsbin http://jsbin.com/miqoxuf/3/edit?html,console,output |
Thanks for the updated jsbin! I will open the issue. |
Fixes an issue where an element with this behavior and
disable-upgrade
throws an error when the element getsdetached
.