Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer leads to an error in combination with disable-upgrade. #71

Closed
wants to merge 3 commits into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Mar 23, 2017

Fixes an issue where an element with this behavior and disable-upgrade throws an error when the element gets detached.

Fixes an issue where an element with this behavior and `disable-upgrade` throws an error when the element gets `detached`.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ghost
Copy link
Author

ghost commented Mar 23, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@valdrinkoshi
Copy link
Member

This is no longer the case with Polymer 2.x or 1.x

@ghost
Copy link
Author

ghost commented Apr 19, 2017

Hi,
thanks for your answer but I can recreate the problem in your jsbin for Polymer 1.x.
If the x-key-aware component with disable-upgrade gets removed from the page, detached of the iron-a11y-keys-behavior is called and leads to an error in _unlistenKeyEventListeners.

image

@valdrinkoshi
Copy link
Member

Oh wow, that looks more a Polymer bug rather than of this behavior... Updated the jsbin http://jsbin.com/miqoxuf/3/edit?html,console,output
Mind opening an issue in https://github.com/Polymer/polymer/issues?

@ghost
Copy link
Author

ghost commented Apr 19, 2017

Thanks for the updated jsbin! I will open the issue.
Am I right that detached should not be called in this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants