2.0 preview #94
2.0 preview #94
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
CLAs look good, thanks! |
e111077
force-pushed
the
2.0-preview
branch
6 times, most recently
from
7cdd4fa
to
c4f309d
Compare
| @@ -189,6 +200,10 @@ | |||
| * transaction, or rejects if an unsupported method is attempted. | |||
| */ | |||
| transaction: function(method, key, value) { | |||
| if (!self.Promise || !this.supportsIndexedDB) { | |||
There was a problem hiding this comment.
Wahhhhhh this repeated if statement blows, but I don't have a better solution
There was a problem hiding this comment.
will remove ifs and console log the error
| var BASE_URI = currentScript.ownerDocument.baseURI; | ||
|
|
||
| // base uri workaround for IE and Safari | ||
| var BASE_URI = document._currentScript ? document._currentScript.baseURI : |
There was a problem hiding this comment.
I think in 2.0 it's currentScript without the underscore, am I right? Wrong? Not sure, that's certain.
There was a problem hiding this comment.
making it certain...
bower.json
Outdated
| }, | ||
| "ignore": [] | ||
| "ignore": [], | ||
| "resolutions": { |
There was a problem hiding this comment.
Don't think resolutions is needed anymore
| // Polymer 2 baseURI polyfill for IE and Safari | ||
| if (Polymer.Element && HTMLImports.importForElement) { | ||
| BASE_URI = HTMLImports.importForElement(document.currentScript).baseURI; | ||
|
|
bower.json
Outdated
| @@ -3,7 +3,7 @@ | |||
| "authors": [ | |||
| "The Polymer Authors" | |||
| ], | |||
| "version": "0.11.0", | |||
There was a problem hiding this comment.
let's check with @cdata that the version here shouldn't be 1.0.0
e111077
force-pushed
the
2.0-preview
branch
2 times, most recently
from
1d81c7a
to
c1b3407
Compare
bower.json
Outdated
| @@ -16,21 +16,43 @@ | |||
| "homepage": "", | |||
| "private": true, | |||
| "dependencies": { | |||
| "promise-polyfill": "polymerlabs/promise-polyfill#^1.0.0", | |||
| "polymer": "polymer/polymer#^1.2.0" | |||
| "polymer": "polymer/polymer#2.0.0-rc.3" | |||
There was a problem hiding this comment.
Should this use ^ to get the latest version of Polymer2? Something like this: https://github.com/PolymerElements/app-route/blob/2.0-preview/bower.json#L19
There was a problem hiding this comment.
nice catch, @frankiefu
|
Tests fail in 1.9.0 due to: |
DO NOT MERGE
Major changes:
Promise polyfill moved to dev dependencies