-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix data and queryParameters not being reset when route becomes inactive #210
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed the CLA! |
CLAs look good, thanks! |
I think you should change your tabsize to 2 spaces instead of 4. Also, the tests are failing |
Tests are obviously the issue right now (adapting them is not), especially since it seems like the expected behavior of the element is to remain how it is if it isn't active. Maybe someone from the polymer elements team can shine some more light on this. |
I checked this approach in my setup with three levels of navigation (
The |
This was a feature intentionally reverted while in beta because of computational cost. It would propagate down the entire routing subtree upon each change. Seeing as there has been repeated requests for this feature, I'd be willing to merge a non-breaking change that hides this feature behind a flag (name I have made up below is crude and I welcome suggestions), so usage would be <app-route clear-data-on-reset route="{{route}}" data="{{firstDataClearsOnReset}}" tail="{{tail}}">
</app-route>
<app-route clear-data-on-reset route="{{tail}}" data="{{secondDataClearsOnReset}}">
</app-route> |
Closing for now since this has gone stale. Reopen with changes if you wish to go this route |
I would love this feature, if it has to be a flag, that sounds fine to me! |
Should fix #206