refune attribute serialization

googlearchive · Apr 2, 2014 · d1bbb25 · d1bbb25
1 parent 1b675dd
commit d1bbb25
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 20 deletions.
diff --git a/binding.js b/binding.js
diff --git a/x-dom-serializer.html b/x-dom-serializer.html
@@ -10,6 +10,7 @@
   <script>
     Polymer('x-serializer', {
       tab: '  ',
+      attributesBlacklist: ['style', 'tabindex', 'role'],
       dumpTag: function(node, indent) {
         if (node.dumpTag) {
           return node.dumpTag(this.dumpTab, indent, this.tab);
@@ -23,7 +24,8 @@
         Object.keys(attributes).forEach(function(k) {
           var v = attributes[k];
           if (v !== null && v !== undefined) {
-            html += ' ' + k + (v !== '' ? '="' + v + '"': '');
+            var sep = typeof v === 'string' && v.indexOf('"') >= 0 ? '\'' : '"';
+            html += ' ' + k + (v !== '' ? '=' + sep + v + sep: '');
           }
         })
         html += '>';
@@ -79,7 +81,11 @@
       },
       // special handling for certain attributes: style, class
       filterAttributes: function(attributes) {
-        attributes.style = null;
+        for (var i in attributes) {
+          if (this.attributesBlacklist.indexOf(i) >= 0 || i.match(/^aria/)) {
+            attributes[i] = null;
+          }
+        }
         var v = attributes['class'];
         v = v ? v.replace(/selected-element/g, '') : null;
         if (v && (v.trim() == 'selected')) {