Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SELENIUM_OVERRIDES available to override from base package.json #3239

Closed
philippw opened this issue Jan 25, 2018 · 2 comments
Closed

Make SELENIUM_OVERRIDES available to override from base package.json #3239

philippw opened this issue Jan 25, 2018 · 2 comments

Comments

@philippw
Copy link

I'm trying to convince wct-local to download selenium and its drivers via an internal Artifactory server instead of directly from GitHub. selenium-standalone supports this via its baseURL settings.

However, as selenium-standalone is a transitive dependency of wct-local I cannot override the default values.
Fortunately, there's the scripts/postinstall.js and its SELENIUM_OVERRIDES, which would allow for excatly that, would it not be the case that it only ever parses settings from wct-local's own package.json`.

Can we change the lookup path from ../package.json to ../../../package.json to be able to override the Selenium settings from the base package.json?

@nicojs
Copy link

nicojs commented Jan 26, 2018

I think using an environment variable for this is more common for these types of features. Also, this issue is reported to the wrong git repository. I think it should be reported to wct-local

See this file: https://github.com/Polymer/wct-local/blob/master/scripts/postinstall.js

@philippw
Copy link
Author

Moved to the correct issues tracker. Closing this bug now.

@aomarks aomarks transferred this issue from Polymer/web-component-tester Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants