diff --git a/.travis.yml b/.travis.yml index 4592b095c..86a947c70 100644 --- a/.travis.yml +++ b/.travis.yml @@ -54,4 +54,8 @@ matrix: sauce_connect: true env: - TEST_COMMAND="xvfb-run npm run test:integration" - - WCT_SAUCE=true + # We can't run Sauce without credentials. PRs from forks don't get secure + # environment variables. Only run Sauce if we have those vars. Note this + # means that community PRs never run on Sauce, even when the builds show + # all green. + - WCT_SAUCE=$TRAVIS_SECURE_ENV_VARS diff --git a/packages/esm-amd-loader/test/run-wct.sh b/packages/esm-amd-loader/test/run-wct.sh index 5be20925a..0c147edf4 100755 --- a/packages/esm-amd-loader/test/run-wct.sh +++ b/packages/esm-amd-loader/test/run-wct.sh @@ -1,6 +1,6 @@ #!/usr/bin/env bash -if [ -n "$WCT_SAUCE" ]; then +if [ "$WCT_SAUCE" = "true" ]; then npx wct --plugin local --plugin sauce else npx wct --plugin local diff --git a/packages/web-component-tester/test/integration/browser.ts b/packages/web-component-tester/test/integration/browser.ts index d8fc75c83..df12df1bf 100644 --- a/packages/web-component-tester/test/integration/browser.ts +++ b/packages/web-component-tester/test/integration/browser.ts @@ -49,7 +49,7 @@ function loadOptionsFile(dir: string): config.Config { const testLocalBrowsers = !process.env.SKIP_LOCAL_BROWSERS; const testLocalBrowsersList = parseList(process.env.TEST_LOCAL_BROWSERS); -const testRemoteBrowsers = process.env.WCT_SAUCE; +const testRemoteBrowsers = process.env.WCT_SAUCE === 'true'; if (testRemoteBrowsers && !(process.env.SAUCE_USERNAME && process.env.SAUCE_ACCESS_KEY)) { throw new Error(