Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build number should not be parsed as integer #937

Closed
nelsonsilva opened this issue Jan 19, 2018 · 2 comments
Closed

Build number should not be parsed as integer #937

nelsonsilva opened this issue Jan 19, 2018 · 2 comments

Comments

@nelsonsilva
Copy link
Contributor

Currently the build number option is parsed as an integer (parseInt(pluginOptions.buildNumber, 10)) but in Sauce this is a "string".
When setting up CI on branches, it is useful to complement the build with extra information so perhaps there's no real reason to enforce it as a number.

@nelsonsilva nelsonsilva changed the title Build number should not be parsed and integer Build number should not be parsed as integer Jan 19, 2018
@aomarks aomarks transferred this issue from Polymer/wct-sauce Jan 3, 2019
@stale
Copy link

stale bot commented Mar 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 4, 2020
@stale
Copy link

stale bot commented Apr 30, 2022

This issue has been automatically closed after being marked stale. If you're still facing this problem with the above solution, please comment and we'll reopen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants