Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work with refereces to external url's (like CDN) #898

Closed
rictic opened this issue Nov 26, 2017 · 4 comments
Closed

Work with refereces to external url's (like CDN) #898

rictic opened this issue Nov 26, 2017 · 4 comments
Labels
Package: editor-service

Comments

@rictic
Copy link
Contributor

rictic commented Nov 26, 2017

From @bahrus on November 25, 2017 17:25

Custom Elements aren't recognized if reference comes from CDN url.

Copied from original issue: Polymer/vscode-plugin#85
@rictic
Copy link
Contributor Author

rictic commented Nov 26, 2017

Interesting. Yeah, that's doable. I suppose from a caching perspective we should assume that such files never change?

@rictic
Copy link
Contributor Author

rictic commented Nov 26, 2017

All that would be necessary is writing a wrapper for FsUrlLoader that can detect http/https urls and return the bytes of the result, otherwise deferring to FsUrlLoader

Wait, no, that may cause all sorts of interesting issues in the analyzer. But good issues, that we should solve. Put forward a proposal in an analyzer issue.

@rictic
Copy link
Contributor Author

rictic commented Nov 30, 2017

dupe of https://github.com/Polymer/polymer-editor-service/issues/4

@rictic rictic closed this as completed Nov 30, 2017
@tedium-bot
Copy link
Collaborator

Issue migrated to polymer/tools#488

@aomarks aomarks transferred this issue from Polymer/polymer-editor-service Jan 3, 2019
@sashafirsov sashafirsov mentioned this issue Jan 27, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Package: editor-service
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rictic @aomarks @tedium-bot