Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete type declaration files without any content #894

Closed
stramel opened this issue Mar 1, 2018 · 1 comment
Closed

Delete type declaration files without any content #894

stramel opened this issue Mar 1, 2018 · 1 comment

Comments

@stramel
Copy link
Contributor

stramel commented Mar 1, 2018

You can see more what I mean here: https://github.com/PolymerElements/marked-element/pull/88/files#diff-8c66e52d6509ca0676ce2b5fbc5e4c4e

/**
 * DO NOT EDIT
 *
 * This file was automatically generated by
 *   https://github.com/Polymer/gen-typescript-declarations
 *
 * To modify these typings, edit the source file(s):
 *   marked-import.html
 */

I have removed the reference that was there in the gen-tsd.json.

{
  "removeReferences": [
    "../marked/lib/marked.d.ts"
  ]
}
@aomarks
Copy link
Member

aomarks commented Mar 1, 2018

We actually prefer to keep these. The reason is that this tool generally mirrors the HTML import graph in it the /// <reference ... statements it inserts. It's simpler to just let files with no declarations exist as empty files, than for all of the other repos that depend on this one to know to remove that reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants