Cancel chunking when disconnected. Fixes #5667 #5668
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there was a pending
requestAnimationFrame
for chunking when thedom-repeat
was disconnected, cancel the rAF so that we're not spending extra cycles creating DOM that no one will see, especially when tearing down/discarding views.__chunkingId
retains its handle upon disconnection as a signal that a render is required to kick chunking back off if thedom-repeat
is subsequently re-connected.Note that this still isn't a guarantee that rendering/chunking can't restart while the
dom-repeat
is disconnected (e.g. if any render-causing properties change while disconnected, such asitems
), since we don't gate all ofdom-repeat
's work on actually being connected; that would be a larger change with the potential to break users relying on the current ability to render while disconnected.Reference Issue
Fixes #5667