Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legacy-undefined-noBatch: Put adoptedStyleSheets use behind a global setting #5645

Merged
merged 5 commits into from
Apr 7, 2020

Conversation

bicknellr
Copy link
Member

Currently, the legacy-undefined-noBatch branch always uses adoptedStyleSheets to share styles between component instances if supported by the browser and provided with built CSS. This PR puts this feature behind a new global setting (shareBuiltCSSWithAdoptedStyleSheets).

@bicknellr bicknellr marked this pull request as ready for review April 3, 2020 17:55
Copy link
Member

@kevinpschaaf kevinpschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look fine. As far as naming the flag, I think useAdoptedStylesheetsWithBuiltCSS might fit a little better?

@bicknellr
Copy link
Member Author

Ok, I updated the name, WDYT?

Copy link
Member

@kevinpschaaf kevinpschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bicknellr bicknellr merged commit 742a103 into legacy-undefined-noBatch Apr 7, 2020
@bicknellr bicknellr deleted the share-built-css-flag branch April 7, 2020 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants