Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.4.0 release notes and commit list #5644

Merged
merged 14 commits into from
Apr 27, 2020
Merged

v3.4.0 release notes and commit list #5644

merged 14 commits into from
Apr 27, 2020

Conversation

bicknellr
Copy link
Member

@bicknellr bicknellr commented Mar 30, 2020 •
edited
Loading

Adds release notes for all the new and changed behavior I could find in the legacy-undefined-noBatch branch. I still need to collect some more info about the feasibility of new behavior around constructable stylesheets. (This behavior is now behind a flag: useAdoptedStyleSheetsWithBuiltCSS.)

@bicknellr
Remove unused externs.
0da4e63
@bicknellr
Started on release notes for legacyUndefined, legacyWarnings, `or…
d80fdca 
…deredComputed`. (...)

These might be too large for release notes and may be better off moved to the
docs site.
@bicknellr
Added notes for fastDomIf, removeNestedTemplates, `suppressNested…
3b6494b 
…Templates`, and `suppressTemplateNotifications`.
@bicknellr bicknellr force-pushed the legacy-undefined-noBatch_release-notes branch from d5f467c to d9c18b4 Compare April 1, 2020 21:40
@bicknellr bicknellr marked this pull request as ready for review April 1, 2020 21:55
@bicknellr
Copy link
Member Author

I added a section on useAdoptedStyleSheetsWithBuiltCSS, PTAL

@bicknellr
Copy link
Member Author

I was just trying out ./util/gen-changelog.sh and it puts commit messages in a list above the old changelog content. I'd like to put these above the raw list of commits, so I wonder if this PR would be better if it went into master as part of the typical post-release changelog commit rather than editing the changelog as part of this branch?

kevinpschaaf
kevinpschaaf reviewed Apr 11, 2020
View reviewed changes
Copy link
Member

@kevinpschaaf kevinpschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great. I have no suggestions for improving the text you've got there, it's all correct fwict.

Only suggestion is to mention the following bugfix, which I think is the only meaningful fix that hasn't been released on master yet:

@bicknellr
Copy link
Member Author

Is that fix enabled by default? (i.e. unrelated to if reuseChunkedInstances is set)

@kevinpschaaf
Copy link
Member

Right, it's an unconditional fix to a behavior that regressed in Polymer 2/3 vs. Polymer 1.

@bicknellr bicknellr force-pushed the legacy-undefined-noBatch_release-notes branch from 4d1eaf5 to 002c98a Compare April 13, 2020 22:47
@bicknellr
Copy link
Member Author

Ok, added, PTAL. Also, what do you think about the PR-moving situation I mentioned earlier?

kevinpschaaf
kevinpschaaf approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@kevinpschaaf kevinpschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Re: when to commit, that's fine to put this content in after generating the commit log.

@bicknellr
Copy link
Member Author

Ok, I'll wait until #5497 is released and then add the commit log to this PR.

@bicknellr bicknellr mentioned this pull request Apr 17, 2020
Merged
@bicknellr bicknellr changed the base branch from legacy-undefined-noBatch to master April 22, 2020 00:08
@bicknellr bicknellr changed the title Adds release notes for legacy-undefined-noBatch v3.4.0 release notes and commit list Apr 27, 2020
@bicknellr bicknellr merged commit 282bd34 into master Apr 27, 2020
@bicknellr bicknellr deleted the legacy-undefined-noBatch_release-notes branch April 27, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpschaaf kevinpschaaf kevinpschaaf approved these changes

@sorvell sorvell Awaiting requested review from sorvell

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bicknellr @kevinpschaaf @googlebot