Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the polyfills; fix a type generation error. #5605

Open
wants to merge 7 commits into
base: legacy-undefined-noBatch-onDemand
Choose a base branch
from

Conversation

bicknellr
Copy link
Member

@bicknellr bicknellr commented Nov 14, 2019

base = class extends base {}; causes a type declare class base extends base {} to be emitted but this fails to verify in the next step. Also, I didn't want to ignore everything called base so I renamed it.


Includes cherry-picked commits from #5607.

@bicknellr bicknellr marked this pull request as ready for review November 14, 2019 02:18
@bicknellr
Copy link
Member Author

Lerna didn't update the dependencies in webcomponentsjs during the last publish because the package itself didn't have changes. Fixing in webcomponents/polyfills#244 and then I'll bump here.

@stale
Copy link

stale bot commented Jan 9, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants