Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround bindings to textarea.placeholder in IE #5577

Merged
merged 2 commits into from
Jul 31, 2019

Commits on Jul 30, 2019

  1. Workaround bindings to textarea.placeholder in IE

    Textareas have a very weird bug in IE, where the text of the placeholder
    is copied to the content of the textarea when set.
    
    This a creates two bugs:
    1. An unintended binding is made to the textContent of the textarea's
       text child node, meaning updates to the `placeholder` will be an
       unnecessary binding process in the best case, or an exception thrown
       when updating the text child node in the worst case.
    2. When `legacyOptimizations` is enabled, the child node of the text
       area is removed when the binding for `placeholder` is processed and
       removed, leaving a binding to a `null` node, and throwing exceptions.
    
    Therefore, when we detect this placeholder behavior, we will remove the
    textnode before template processing, preventing both bugs.
    dfreedm committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    61767da View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2019

  1. Configuration menu
    Copy the full SHA
    ab49f51 View commit details
    Browse the repository at this point in the history