Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @override, remove @attribute/@group/@hero/@homepage #5559

Merged
merged 1 commit into from
Jun 19, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/elements/dom-module.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ function styleOutsideTemplateCheck(inst) {
*/
export class DomModule extends HTMLElement {

/** @override */
static get observedAttributes() { return ['id']; }

/**
Expand Down
1 change: 1 addition & 0 deletions lib/legacy/legacy-element-mixin.js
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,7 @@ export const LegacyElementMixin = dedupingMixin((base) => {
* @this {Element}
* @return {?Node} The element whose local dom within which this element is
* contained.
* @override
*/
get domHost() {
let root = wrap(this).getRootNode();
Expand Down
2 changes: 2 additions & 0 deletions lib/legacy/mutable-data-behavior.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ export const MutableDataBehavior = {
* @param {*} old Previous property value
* @return {boolean} Whether the property should be considered a change
* @protected
* @override
*/
_shouldPropertyChange(property, value, old) {
return mutablePropertyChange(this, property, value, old, true);
Expand Down Expand Up @@ -142,6 +143,7 @@ export const OptionalMutableDataBehavior = {
* @param {*} old Previous property value
* @return {boolean} Whether the property should be considered a change
* @protected
* @override
*/
_shouldPropertyChange(property, value, old) {
return mutablePropertyChange(this, property, value, old, this.mutableData);
Expand Down
1 change: 1 addition & 0 deletions lib/mixins/element-mixin.js
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,7 @@ export const ElementMixin = dedupingMixin(base => {
}
}

/** @override */
this.prototype._template = template;
}

Expand Down
1 change: 1 addition & 0 deletions lib/utils/templatize.js
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,7 @@ class TemplateInstanceBase extends templateInstanceBase {
*
* @param {Event} event Event to dispatch
* @return {boolean} Always true.
* @override
*/
dispatchEvent(event) { // eslint-disable-line no-unused-vars
return true;
Expand Down