Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various compilation fixes for externs #5550

Merged
merged 10 commits into from
Jun 6, 2019
Merged

Various compilation fixes for externs #5550

merged 10 commits into from
Jun 6, 2019

Commits on May 30, 2019

  1. Fix GestureEventListeners generated externs name. 

    Due to some compiler weirdness, we recently added some hacky indirection
around GestureEventListeners, however this changed the name of that
mixin from Analyzer's perspective by adding a leading underscore. This
fixes that.
    @aomarks
    aomarks committed May 30, 2019
    Configuration menu
    Copy the full SHA
    cdd4e20 View commit details
    Browse the repository at this point in the history

  2. Add @Suppress annotation for use of deprecated cssFromModules

    @aomarks
    aomarks committed May 30, 2019
    Configuration menu
    Copy the full SHA
    54b1d78 View commit details
    Browse the repository at this point in the history

  3. Fix old global namespace type annotation for TemplateInstanceBase

    @aomarks
    aomarks committed May 30, 2019
    Configuration menu
    Copy the full SHA
    fc190dd View commit details
    Browse the repository at this point in the history

  4. Annotate __dataEnabled in a way analyzer understands

    @aomarks
    aomarks committed May 30, 2019
    Configuration menu
    Copy the full SHA
    e4e9e2f View commit details
    Browse the repository at this point in the history

  5. Add @return annotation for PROPERTY_EFFECT_TYPES getter

    @aomarks
    aomarks committed May 30, 2019
    Configuration menu
    Copy the full SHA
    3dd189c View commit details
    Browse the repository at this point in the history

  6. Align signatures of attributeChangedCallback

    @aomarks
    aomarks committed May 30, 2019
    Configuration menu
    Copy the full SHA
    4cc6c33 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2019

  1. Add new mixin annotations, remove GestureEventListeners alias

    @aomarks
    aomarks committed May 31, 2019
    Configuration menu
    Copy the full SHA
    0ae14b9 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2019

  1. Add some casts for places Closure doesn't understand constructor

    @aomarks
    aomarks committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    10d43ce View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2019

  1. Fix eslint errors.

    @aomarks
    aomarks committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    6dfaa5f View commit details
    Browse the repository at this point in the history

  2. Pin to firefox 66 because of selenium error

    @aomarks
    aomarks committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    f0fb532 View commit details
    Browse the repository at this point in the history