Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scopesubtree same scope #5544

Merged
merged 3 commits into from
May 20, 2019
Merged

Scopesubtree same scope #5544

merged 3 commits into from
May 20, 2019

Conversation

dfreedm
Copy link
Member

@dfreedm dfreedm commented May 20, 2019

Reference Issue

@dfreedm
Make sure scopeSubtree does not recurse through other ShadowRoots
8a5c1e9 
Polymer v1 implementation of `scopeSubtree` actually only added scoping
classes, and thus would have most of the effect of stopping at
ShadowRoot boundaries.

This change is more consistent with Polymer v1 behavior, without a weird
intersection of styling behavior.
@dfreedm
remove debugger line
634d736
@dfreedm dfreedm requested a review from sorvell May 20, 2019 21:36
@dfreedm dfreedm merged commit 927ae6a into master May 20, 2019
@dfreedm dfreedm deleted the scopesubtree-same-scope branch May 20, 2019 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorvell sorvell sorvell approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

@TimvdLippe TimvdLippe Awaiting requested review from TimvdLippe

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dfreedm @sorvell @googlebot