Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run resolveUrl for protocol-relative urls #5530

Merged
merged 3 commits into from
Apr 26, 2019
Merged

Run resolveUrl for protocol-relative urls #5530

merged 3 commits into from
Apr 26, 2019

Commits on Apr 25, 2019

  1. Run resolveUrl for protocol-relative urls 

    This part of ABS_URL is trying to match on absolute paths, like `/images/logo.png` not protocol-relative urls like `//example.com/images/logo.png`

Upstreaming cl/245302268
    @rictic
    rictic authored Apr 25, 2019
    Configuration menu
    Copy the full SHA
    3a26bf6 View commit details
    Browse the repository at this point in the history

  2. Added a test and confirmed that it fails without this change. 

    Also cleaned up a some over-aggressive modulizer escaping in resolveurl-elements.js
    @rictic
    rictic committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    2947d96 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2019

  1. Remove debugger statement

    @rictic
    rictic committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    69068c6 View commit details
    Browse the repository at this point in the history