Upstream compilation fixes #5528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add @nocollapse to all of our static methods and properties, because we never want static property collapsing on these methods.
This improves the closure compiler type checking of GestureEventListeners. Upstreaming of cl/239878806
rictic
requested review from
kevinpschaaf,
sorvell and
TimvdLippe
as code owners
|
@ChadKillingsworth FYI, this includes workarounds for google/closure-compiler#3240 |
|
Would it be possible to port this change over to 2.x and create a patch release for Polymer 2.8? Our project uses Polymer2 (interim; we have plans to upgrade to 3.x ultimately) with Closure compiler and we had to use a weird hack to get around the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.