Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid upgrading template if no hostProps, for better perf. #5520

Merged
merged 3 commits into from
Apr 13, 2019
Merged

Avoid upgrading template if no hostProps, for better perf. #5520

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65a5b48
Avoid upgrading template if no hostProps, for better perf.
kevinpschaaf Apr 10, 2019
f1a9d4f
Simplify
kevinpschaaf Apr 10, 2019
c7eb7c1
[ci skip] Add comment
kevinpschaaf Apr 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/utils/templatize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,11 +360,14 @@ function createTemplatizerClass(template, templateInfo, options) {
}

/**
* Adds propagate effects from the template to the template instance for
* properties that the host binds to the template using the `_host_` prefix.
*
* @suppress {missingProperties} class.prototype is not defined for some reason
*/
function addPropagateEffects(template, templateInfo, options) {
let userForwardHostProp = options.forwardHostProp;
if (userForwardHostProp) {
if (userForwardHostProp && templateInfo.hasHostProps) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a comment here or perhaps just in the doc for the function explaining what this does so it's clear why it's only related to hostProps.

// Provide data API and property effects on memoized template class
let klass = templateInfo.templatizeTemplateClass;
if (!klass) {
Expand Down Expand Up @@ -423,6 +426,11 @@ function addNotifyEffects(klass, template, templateInfo, options) {
}
if (options.forwardHostProp && template.__dataHost) {
for (let hprop in hostProps) {
// As we're iterating hostProps in this function, note whether
// there were any, for an optimization in addPropagateEffects
if (!templateInfo.hasHostProps) {
templateInfo.hasHostProps = true;
}
klass.prototype._addPropertyEffect(hprop,
klass.prototype.PROPERTY_EFFECT_TYPES.NOTIFY,
{fn: createNotifyHostPropEffect()});
Expand Down