Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure className bindings work correctly when ShadyDOM.noPatch is… #5518

Merged
merged 9 commits into from
Apr 20, 2019
Merged

Ensure className bindings work correctly when ShadyDOM.noPatch is… #5518

merged 9 commits into from
Apr 20, 2019

Commits on Apr 2, 2019

  1. Ensure className bindings work correctly when ShadyDOM.noPatch is… 

    … used.

Puts `className` on `Polymer.dom` and ensures any sets to `className` in the binding system, go through that wrapper.

Note, depends on webcomponents/shadydom#326.
    Steven Orvell committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    eb2385a View commit details
    Browse the repository at this point in the history

  2. Address review feedback via comment.

    Steven Orvell committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    4e1d6a1 View commit details
    Browse the repository at this point in the history

  3. fix lint issues

    @dfreedm
    dfreedm committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    439c245 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2019

  1. fix closure compiler error

    @dfreedm
    dfreedm committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    002ef94 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2019

  1. Update webcomponents dev dependency for testing className fix

    @dfreedm
    dfreedm committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    a1c67e4 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2019

  1. Fix className on browsers without good native accessors 

    * Ensure `wrap` falls back to using `ShadyDOM.patch` when `noPatch` is not in use so that `className` can be used.
* Ensure `Polymer.dom` uses `patch` when `noPatch` is not in use so that `className` can be used.
    Steven Orvell committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    b13e656 View commit details
    Browse the repository at this point in the history

  2. Fix typo

    Steven Orvell committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    6adbc23 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2019

  1. upgrade dependencies.

    Steven Orvell committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    3b7c9f8 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2019

  1. Merge branch 'master' into fix-className-bindings-master

    @dfreedm
    dfreedm committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    652fea9 View commit details
    Browse the repository at this point in the history