Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix class name bindings #5517

Closed
wants to merge 2 commits into from
Closed

Fix class name bindings #5517

wants to merge 2 commits into from

Conversation

sorvell
Copy link
Contributor

@sorvell sorvell commented Apr 1, 2019

Puts className on Polymer.dom and ensures any sets to className in the binding system, go through that wrapper.

Note, depends on webcomponents/shadydom#326.

Steven Orvell added 2 commits April 1, 2019 11:59
Ensure className bindings work correctly when ShadyDOM.noPatch is…
41bcb1c 
… used.

Puts `className` on `Polymer.dom` and ensures any sets to `className` in the binding system, go through that wrapper.

Note, depends on webcomponents/shadydom#326.
To ease page setup, take all settings optionally off the Polymer gl…
81850b0 
…obal.
@sorvell sorvell requested a review from TimvdLippe as a code owner April 1, 2019 19:01
@sorvell
Copy link
Contributor Author

sorvell commented Apr 2, 2019

Closing in favor of #5518

@sorvell sorvell closed this Apr 2, 2019
@sorvell sorvell deleted the fix-className-bindings branch April 3, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfreedm dfreedm Awaiting requested review from dfreedm

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

@TimvdLippe TimvdLippe Awaiting requested review from TimvdLippe

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sorvell @googlebot