Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional debouncer fixes #5509

Merged
merged 4 commits into from
Mar 14, 2019
Merged

Additional debouncer fixes #5509

merged 4 commits into from
Mar 14, 2019

Conversation

kevinpschaaf
Copy link
Member

Additional updates to #5499 and #5508 based on internal testing:

  • Don't clear set at the end for flushDebouncers reentrancy robustness (they will be deleted from queue when they run, so queue should always be empty when forEach returns.
  • Remove debouncer from queue before running debouncer callback, to protect against callback calling flush()

Reference Issue

Fixes #5250

@kevinpschaaf kevinpschaaf merged commit 3079cae into master Mar 14, 2019
@kevinpschaaf kevinpschaaf deleted the 5250-dequeue-before-run branch March 14, 2019 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants