Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ShadyDOM.attachDom #5487

Merged
merged 8 commits into from
Apr 19, 2019
Merged

Use ShadyDOM.attachDom #5487

merged 8 commits into from
Apr 19, 2019

Conversation

sorvell
Copy link
Contributor

@sorvell sorvell commented Feb 14, 2019

This is a more optimized way to create and populate a shadowRoot.

This depends on webcomponents/shadydom#316 and a new version of webcomponentsjs.

This is a more optimized way to create and populate a `shadowRoot`.
@sorvell sorvell changed the title Use ShadyDOM.upgrade Use ShadyDOM.attachDom Apr 10, 2019
Copy link
Member

@dfreedm dfreedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dfreedm dfreedm merged commit 176c001 into master Apr 19, 2019
@dfreedm dfreedm deleted the shadydom-upgrade branch April 19, 2019 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants