Ensure that marshalArgs pulls wildcard info value from __data #5476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It currently pulls the value from `changedProps` rather than __data, meaning it could provide stale data for re-entrant changes.
kevinpschaaf
requested review from
dfreedm,
sorvell and
TimvdLippe
as code owners
sorvell
suggested changes
Feb 1, 2019
lib/mixins/property-effects.js
Outdated
| if (structured) { | ||
| let value = get(data, path); | ||
| // when data is not stored e.g. `splices`, get the changed value | ||
| if (value === undefined) { |
There was a problem hiding this comment.
So we want to pull the live value here, but we fall back to the stored value in props for splices. Adding a specific check for splices would be best but might be a performance hit. What if we take the value in props only if it is not === undefined? This allows the live value to be undefined which it sometimes can be.
There was a problem hiding this comment.
Added skipped tests and TODO to address this in a separate change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It currently pulls the value from
changedPropsrather than __data, meaning it could provide stale data for re-entrant changes.Reference Issue
Fixes #5475