Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @override from static methods on mixins. #5467

Merged
merged 2 commits into from
Jan 15, 2019
Merged

Remove @override from static methods on mixins. #5467

merged 2 commits into from
Jan 15, 2019

Commits on Jan 15, 2019

  1. Remove @override from static methods on mixins. 

    Closure compiler is improving its handling of class inheritance, and it does not understand our mixins well enough to notice that these methods override their superclasses. These annotations cause compiler errors in an upcoming version of the compiler.
    @rictic
    rictic committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    f15b137 View commit details
    Browse the repository at this point in the history

  2. Lint clean

    @rictic
    rictic committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    bdcd37c View commit details
    Browse the repository at this point in the history