Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get Polymer compiling clean under closure recommended flags #5424

Merged
merged 10 commits into from
Feb 5, 2019
Merged

Get Polymer compiling clean under closure recommended flags #5424

merged 10 commits into from
Feb 5, 2019

Commits on Aug 28, 2018

  1. Upstream changes to externs

    @kevinpschaaf
    kevinpschaaf committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    83834af View commit details
    Browse the repository at this point in the history

  2. Upstream warning text.

    @kevinpschaaf
    kevinpschaaf committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    b4d6e70 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2018

  1. Fix jsdoc comment

    @kevinpschaaf
    kevinpschaaf committed Aug 29, 2018
    Configuration menu
    Copy the full SHA
    e69c8b3 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2018

  1. Get Polymer compiling clean under closure recommended flags 

    With these changes we have zero errors and zero warnings with `RECOMMENDED_FLAGS`!

Most of the changes were adding `@override` for methods and properties in mixins. Apparently if you implement an interface you need to say `@override` for each method or property on the interface. This combines with our mixin strategy to the tune of needing to add `@override` on every non-private method and property.

I'm not sure this is intended behavior of the compiler. Filed google/closure-compiler#3137 to see if it is.
    @rictic
    rictic committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    566dcfa View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2018

  1. Fix merge conflict around toggleAttribute

    @rictic
    rictic committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    419dce6 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2018

  1. Get typescript compiling again.

    @rictic
    rictic committed Nov 10, 2018
    Configuration menu
    Copy the full SHA
    bbf24c0 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2018

  1. Document properties for eslint.

    @rictic
    rictic committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    3a4db3b View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2019

  1. Merge branch 'master' into strict-no-warnings

    @kevinpschaaf
    kevinpschaaf committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    77ac3ec View commit details
    Browse the repository at this point in the history

  2. Merge branch 'strict-no-warnings' into sync-externs

    @kevinpschaaf
    kevinpschaaf authored Feb 5, 2019
    Configuration menu
    Copy the full SHA
    19dd467 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #5348 from Polymer/sync-externs 

    Upstream changes to externs
    @kevinpschaaf
    kevinpschaaf authored Feb 5, 2019
    Configuration menu
    Copy the full SHA
    6611abe View commit details
    Browse the repository at this point in the history