Get Polymer compiling clean under closure recommended flags #5424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With these changes we have zero errors and zero warnings with `RECOMMENDED_FLAGS`! Most of the changes were adding `@override` for methods and properties in mixins. Apparently if you implement an interface you need to say `@override` for each method or property on the interface. This combines with our mixin strategy to the tune of needing to add `@override` on every non-private method and property. I'm not sure this is intended behavior of the compiler. Filed google/closure-compiler#3137 to see if it is.
rictic
requested review from
kevinpschaaf,
sorvell and
TimvdLippe
as code owners
TimvdLippe
suggested changes
Nov 5, 2018
|
@azakus got the typescript types compiling too, PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes we have zero errors and zero warnings with
RECOMMENDED_FLAGS!Most of the changes were adding
@overridefor methods and properties in mixins. Apparently if you implement an interface you need to say@overridefor each method or property on the interface. This combines with our mixin strategy to the tune of needing to add@overrideon every non-private method and property.I'm not sure this is intended behavior of the compiler. Filed google/closure-compiler#3137 to see if it is.
Downstreamed as cl/220013205