make toggleAttribute match with native signature

[43081j]

Fixes #5364, again.

This solution is needed instead of #5371 as that would break TS definitions for consumers using TS <3.1.

I had to use arguments (unfortunately) because otherwise the function signature does not match the JSDoc, which seems more confusing than a a little arguments check.

This produces correct types which are identical to the native toggleAttribute, while still supporting our third argument behind the scenes in JS.

cc @TimvdLippe
Supersedes and closes #5371

[TimvdLippe]

SFTM. I will let @keanulee review as well.

[keanulee]

This seems fine to me. @azakus you think this will be okay for internal users?

[43081j]

Any chance we can get this merged?

Also, does anyone know what the plan is for next release so i have a rough idea of when we'll get this? (the next time we tag & npm publish it)

[keanulee]

cc @rictic @aomarks do you think this will be okay for internal users?

[rictic]

Yeah, I don't see anything that should be a problem for internal users.

We're still on TS <3.1 internally too, so that's a bonus.