implement native toggleAttribute signature #5370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43081j
requested review from
dfreedm,
kevinpschaaf,
sorvell and
TimvdLippe
as code owners
|
No worries, tried it locally on a project too and it resolves the problem 👍 |
TimvdLippe
suggested changes
Oct 8, 2018
lib/legacy/legacy-element-mixin.js
Outdated
| @@ -817,7 +817,7 @@ export const LegacyElementMixin = dedupingMixin((base) => { | |||
| * @param {boolean=} bool Boolean to force the attribute on or off. | |||
| * When unspecified, the state of the attribute will be reversed. | |||
| * @param {Element=} node Node to target. Defaults to `this`. | |||
| * @return {void} | |||
| * @return {boolean} | |||
There was a problem hiding this comment.
/home/travis/build/Polymer/polymer/lib/legacy/legacy-element-mixin.js
813:5 error Missing JSDoc return description valid-jsdoc
This was referenced Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5364.
As long as we return bool, we implement the same interface that was natively introduced recently. While keeping our third parameter..