From 6157826e9e7d8a49158dfcccc2e52e00d200ca79 Mon Sep 17 00:00:00 2001 From: Florian Ribon Date: Thu, 4 Oct 2018 17:17:16 -0700 Subject: [PATCH] Update jsdoc for PropertyEffects.splice Array.prototype.splice has its "deleteCount" parameter optional. When omitted, all items of the arrays are removed. This works with a polymer element "splice" method, but the typing does not correspond and TypeScript prevents it. Fixes #5366 --- lib/mixins/property-effects.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/mixins/property-effects.js b/lib/mixins/property-effects.js index e43bccc562..b36c620f87 100644 --- a/lib/mixins/property-effects.js +++ b/lib/mixins/property-effects.js @@ -1873,7 +1873,7 @@ export const PropertyEffects = dedupingMixin(superClass => { * * @param {string | !Array} path Path to array. * @param {number} start Index from which to start removing/inserting. - * @param {number} deleteCount Number of items to remove. + * @param {number=} deleteCount Number of items to remove. * @param {...*} items Items to insert into array. * @return {Array} Array of removed items. * @public