Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup element-mixin leftovers from modulizer #5330

Merged
merged 1 commit into from
Aug 17, 2018
Merged

Cleanup element-mixin leftovers from modulizer #5330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions lib/mixins/element-mixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,17 +720,6 @@ export const ElementMixin = dedupingMixin(base => {
return PolymerElement;
});

/**
* Provides basic tracking of element definitions (registrations) and
* instance counts.
*
* @summary Provides basic tracking of element definitions (registrations) and
* instance counts.
*/
`TODO(modulizer): A namespace named Polymer.telemetry was
declared here. The surrounding comments should be reviewed,
and this string can then be deleted`;

/**
* Total number of Polymer element instances created.
* @type {number}
Expand Down Expand Up @@ -760,7 +749,7 @@ function _regLog(prototype) {
*/
export function register(prototype) {
registrations.push(prototype);
undefined && _regLog(prototype);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is right. In 2.x this only logged if Polymer.log was set. Modulizer made it never log, which isn't great, but after this change we'll always log, which we also don't want.

IMO we should invent a global name that, when truthy, means that we'll log here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rictic Ah crap, you are correct! Reinvent the Polymer.log setting? 😂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say let's just remove the registration logging altogether in 3.x. I don't know that this feature was ever documented, and the whole registration tracking system is fairly dubious now that WC V1 has a registry API.

Will make a new PR to remove that line; dumpRegistrations can remain.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5331

_regLog(prototype);
}

/**
Expand Down