Cleanup element-mixin leftovers from modulizer #5330
Merged
+1
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimvdLippe
requested review from
dfreedm,
kevinpschaaf and
sorvell
as code owners
rictic
reviewed
Aug 17, 2018
| @@ -760,7 +749,7 @@ function _regLog(prototype) { | |||
| */ | |||
| export function register(prototype) { | |||
| registrations.push(prototype); | |||
| undefined && _regLog(prototype); | |||
There was a problem hiding this comment.
I don't think this is right. In 2.x this only logged if Polymer.log was set. Modulizer made it never log, which isn't great, but after this change we'll always log, which we also don't want.
IMO we should invent a global name that, when truthy, means that we'll log here.
There was a problem hiding this comment.
@rictic Ah crap, you are correct! Reinvent the Polymer.log setting? 😂
There was a problem hiding this comment.
I'd say let's just remove the registration logging altogether in 3.x. I don't know that this feature was ever documented, and the whole registration tracking system is fairly dubious now that WC V1 has a registry API.
Will make a new PR to remove that line; dumpRegistrations can remain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was some leftover output from modulizer that we can remove.
Reference Issue
Closes #5315