Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TemplateStamp event listen param types from Node to EventTarget. #5320

Merged
merged 4 commits into from
Aug 11, 2018
Merged

Update TemplateStamp event listen param types from Node to EventTarget. #5320

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
014a59f
Update TemplateStamp event listen param types from Node to EventTarget.
aomarks Aug 10, 2018
aff4d35
Also update Node->EventTarget in GestureEventListeners.
aomarks Aug 10, 2018
3da8462
Also update gestures.js
aomarks Aug 10, 2018
f4dd733
Node->HTMLElement
aomarks Aug 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/mixins/template-stamp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ export const TemplateStamp = dedupingMixin(
* This method generates a handler function that looks up the method
* name at handling time.
*
* @param {!Node} node Node to add listener on
* @param {!EventTarget} node Node to add listener on
* @param {string} eventName Name of event
* @param {string} methodName Name of method
* @param {*=} context Context the method will be called on (defaults
Expand All @@ -462,7 +462,7 @@ export const TemplateStamp = dedupingMixin(
/**
* Override point for adding custom or simulated event handling.
*
* @param {!Node} node Node to add event listener to
* @param {!EventTarget} node Node to add event listener to
* @param {string} eventName Name of event
* @param {function(!Event):void} handler Listener function to add
* @return {void}
Expand All @@ -475,7 +475,7 @@ export const TemplateStamp = dedupingMixin(
/**
* Override point for adding custom or simulated event handling.
*
* @param {!Node} node Node to remove event listener from
* @param {!EventTarget} node Node to remove event listener from
* @param {string} eventName Name of event
* @param {function(!Event):void} handler Listener function to remove
* @return {void}
Expand Down