Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Make event notification handler read the value from currentTarget, #5313

Merged
merged 1 commit into from
Aug 2, 2018
Merged

[3.x] Make event notification handler read the value from currentTarget, #5313

merged 1 commit into from
Aug 2, 2018

Conversation

tomalec
Copy link
Contributor

@tomalec tomalec commented Aug 2, 2018

instead of target which may not be bound to any data.

Reference Issue

Fixes #5308

Clone of #5309

@tomalec
Make event notification handler read the value from currentTarget,
86e5a51 
instead of target which may not be bound to any data.

Fixes Polymer#5308
@tomalec tomalec mentioned this pull request Aug 2, 2018
Merged
TimvdLippe
TimvdLippe approved these changes Aug 2, 2018
View reviewed changes
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@TimvdLippe TimvdLippe merged commit db2f3cc into Polymer:master Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimvdLippe TimvdLippe TimvdLippe approved these changes

@dfreedm dfreedm Awaiting requested review from dfreedm

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

@sorvell sorvell Awaiting requested review from sorvell

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomalec @TimvdLippe @googlebot