Make event notification handler read the value from currentTarget, #5309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomalec
requested review from
dfreedm,
kevinpschaaf,
sorvell and
TimvdLippe
as code owners
4 tasks
TimvdLippe
approved these changes
Jul 30, 2018
There was a problem hiding this comment.
This LGTM. We do have to run this through Sauce though to see if we broke browser-compatibility (IE, looking at you). @azakus Do you mind pushing to a branch on our repo to kick off Travis for that?
TimvdLippe
reviewed
Jul 30, 2018
test/unit/property-effects.html
Outdated
| el.$.boundChild.customEventValue = 42; | ||
| child.dispatchEvent(new Event('custom', {bubbles: true})); | ||
| console.warn(el.$.boundChild.customEventValue); | ||
| console.warn(el.$.boundChild.customEventValue); |
There was a problem hiding this comment.
Oh, do you mind removing these?
instead of target which may not be bound to any data. Fixes Polymer#5308
tomalec
force-pushed
the
issues/5308-event-notification-handler
branch
from
f1600f3
to
7a00b3c
Compare
|
I have pushed the branch to our repository. Travis build running at https://travis-ci.org/Polymer/polymer/builds/411197150?utm_source=github_status&utm_medium=notification |
|
Confirmed working 🎉 Merging this one. @tomalec Could you open a similar PR to master as well? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of the
targetwhich may not be bound to any data.Reference Issue
Fixes #5308
Related to 1.x issue #2497