Fix shady test regressions (3.x) #5288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinpschaaf
requested review from
dfreedm,
sorvell and
TimvdLippe
as code owners
TimvdLippe
approved these changes
Jul 13, 2018
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes shady CSS test regressions that occurred based on changes in webcomponents/shadycss#187.
Since on browsers without custom properties, shadycss scoping may be flushed synchronous to custom element upgrade, this changed the timing that scoping classes could be applied to elements. The
getComposedHTMLhelper function in the shady tests has been updated to strip scoping classes, so that the test assertions don't need to care about this timing difference.This change also applies changes already made on master to extend 3 Edge test skips beyond just Edge 16 to all versions of Edge. Same for Safari keyframe tests.